Add jdk.management.agent module to server boot layer on start #123938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Mar 4, 2025
| .findModule(module.getName()) | ||
| .map(ResolvedModule::reference) | ||
| .orElse(null); | ||
| return module == PolicyManager.class.getModule() || (moduleReference != null && systemModules.contains(moduleReference)); |
There was a problem hiding this comment.
If it's the entitlements module we could return earlier? Then we don't need to do the reference unwrapping.
mark-vieira
changed the title
|
@rjernst as discussed I've modified this to simply add the |
This was referenced Mar 4, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 4, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 4, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some system modules are not initially loaded by the boot module layer. An example is something like
jdk.management.agentwhich dynamically loaded by various external tools, such as IDEs when performing thread or heap dumps.We now proactively add this module via
--add-modulesto the server so it's known to thePolicyManageron startup.